-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IDB Ignore] Icons folder reorganization and cleaning #7021
Draft
Blundir
wants to merge
170
commits into
cmss13-devs:master
Choose a base branch
from
Blundir:reorg_file
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+14,431
−13,836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Sprites
Remove the soul from the game.
Refactor
Make the code harder to read
labels
Aug 23, 2024
cm13-github
added
the
Merge Conflict
PR can't be merged because it touched too much code
label
Nov 9, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
removed
the
Merge Conflict
PR can't be merged because it touched too much code
label
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code Improvement
Make the code longer
Fix
Fix one bug, make ten more
Mapping
did you remember to save in tgm format?
Refactor
Make the code harder to read
Sprites
Remove the soul from the game.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Splits and reorganizes tons of heavy dmi files, removes some completely unused icons.
No changes to existing icons, no new ones are added.
No player facing changes.
Explain why it's good for the game
We hit icon state cap (512) in certain files, and not to mention the amount of merge conflicts overloaded files have.
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
refactor: reorganized and cleaned many dmis in icons folder
/:cl: