Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDB Ignore] Icons folder reorganization and cleaning #7021

Draft
wants to merge 170 commits into
base: master
Choose a base branch
from

Conversation

Blundir
Copy link
Contributor

@Blundir Blundir commented Aug 23, 2024

About the pull request

Splits and reorganizes tons of heavy dmi files, removes some completely unused icons.

No changes to existing icons, no new ones are added.

No player facing changes.

Explain why it's good for the game

We hit icon state cap (512) in certain files, and not to mention the amount of merge conflicts overloaded files have.

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
refactor: reorganized and cleaned many dmis in icons folder
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Refactor Make the code harder to read labels Aug 23, 2024
@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Aug 27, 2024
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Nov 9, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Fix Fix one bug, make ten more Mapping did you remember to save in tgm format? Refactor Make the code harder to read Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants